Changeset 5948

Timestamp:

01/18/12 19:24:15 (4 months ago)

Author:

vain

Message:

• setAttribute() will use a setterMethod in DEBUG mode to protect the developer
• in live mode the attribute is assigned directly to the property
• closes ticket #211

File:

• trunk/core/viewhelper/form/formelement.php (modified) (1 diff)

trunk/core/viewhelper/form/formelement.php

@@ -416 +416 @@
             {
                 /**
-                 * attributes are directly set
-                 * one might even set a wrong one by accident, like $attribute = 'maxxxlength'
-                 * protect the developer a little bit more here.
-                 * @todo check if attribute is allowed, lookup in whitelist
-                 * @todo protect formelement attr and use setters
+                 * In DEBUG mode the attributes are set via a setter method.
+                 * So one might even set a wrong one by accident, like $attribute = 'maxxxlength'.
+                 * To protect the developer a bit more, we are focing the usage of a setter method.
+                 * If the setter method exists most likely the property will exist too, i guess.
                  */
-
-                # set attribute directly
-                $this->{$attribute} = $value;
+                if(DEBUG == true)
+                {
+                    $method = 'set' . $attribute;
+                    $this->{$method}($value);
+                }
+                else # while in production mode
+                {
+                    # set attribute directly
+                    $this->{$attribute} = $value;
+                }
             }
         }